Repository navigation
Do not partially use text blocks - #273
Merged
Merged
Conversation
timtebeek
marked this pull request as ready for review
August 16, 2023 17:49
kunli2
approved these changes
Aug 16, 2023
kunli2
left a comment
kunli2
left a comment
Contributor
There was a problem hiding this comment.
This makes sense, LGTM. thanks Tim!
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
No longer, for the time being, concatenate text blocks unless they are fully composed of string literals.
What's your motivation?
Before we would end up with partial conversions when SQL statements for instance used variables in the concatenation, which resulted in less than ideal text blocks. While we wait for a proper fix in #261 this
Fixes #260
Have you considered any alternatives or workarounds?
A separate check seemed easier than squeezing this into
flatAdditiveStringLiterals, especially if we revisit this with #261Any additional context